This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix 64x32 handling in gdbserver/linux-x86-low.c:ps_get_thread_area
- From: Doug Evans <dje at google dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 5 Jun 2013 14:28:17 -0700
- Subject: Re: [patch] Fix 64x32 handling in gdbserver/linux-x86-low.c:ps_get_thread_area
- References: <yjt24ndru9yf dot fsf at ruffy2 dot mtv dot corp dot google dot com> <51A0D2EC dot 80209 at redhat dot com>
On Sat, May 25, 2013 at 8:04 AM, Pedro Alves <palves@redhat.com> wrote:
> Fun. Thanks for the detailed analysis.
>
> On 05/25/2013 02:25 AM, Doug Evans wrote:
>
>> - *(int *)base = desc[1];
>> + /* Ensure we properly extend the value to 64-bits for x86_64. */
>> + *base = (void*) (uintptr_t) desc[1];
>
> missing space: 'void *'.
>
> Otherwise OK.
>
> Thanks,
> --
> Pedro Alves
Patch committed to 7.6 branch as well (and 7.6 wiki updated).