This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v5 1/3] New remove-symbol-file command.

From: Luis Machado <lgustavo at codesourcery dot com>
To: "Blanc, Nicolas" <nicolas dot blanc at intel dot com>
Cc: Doug Evans <dje at google dot com>, Pedro Alves <palves at redhat dot com>, Tom Tromey <tromey at redhat dot com>, Eli Zaretskii <eliz at gnu dot org>, Yao Qi <yao at codesourcery dot com>, "lgustavo at codesourcery dot com" <lgustavo at codesourcery dot com>, gdb-patches <gdb-patches at sourceware dot org>
Date: Tue, 04 Jun 2013 19:59:27 +0200
Subject: Re: [PATCH v5 1/3] New remove-symbol-file command.
References: <1370021520-23150-1-git-send-email-nicolas dot blanc at intel dot com> <1370021520-23150-2-git-send-email-nicolas dot blanc at intel dot com> <CADPb22TpOqZy4hiPOBLHm+_4TSB_tMJ+ak5taMTJr6b3EC5TLg at mail dot gmail dot com> <388084C8C1E6A64FA36AD1D656E485661A79B7B3 at IRSMSX106 dot ger dot corp dot intel dot com>
Reply-to: lgustavo at codesourcery dot com

On 06/04/2013 06:40 PM, Blanc, Nicolas wrote:

Still, IWBN to be able to specify a file name.  Maybe even a regex.
That doesn't have to be implemented today, but IWBN to confirm it can be added later without any trouble.
Presumably "remove-symbol-file -r" will cause an error, and thus tomorrow we could implement "remove-symbol-file -r regex".
?

OTOH, one could have "remove-symbol-file file" or "remove-symbol-file regex", and require the address version to be specified as "remove-symbol-file -a addr".

Which will be more common?


It would be ok for me to support the following command switches:

remove-symbol-file addr ADDR
remove-symbol-file file FILE

So for instance remove-symbol-file file /tmp/myfile.so would then
remove the first user-added occurrence of /tmp/myfile.so.
Additional switches and options could then be implemented later on.

Please let me know if you would be happy with this change. Does
anyone have an objection to the syntax above?

Personally i like Doug's suggestions better, namely the -a, -r and -fswitches, for example.

References:
- Re: [PATCH v5 1/3] New remove-symbol-file command.
  - From: Doug Evans
- RE: [PATCH v5 1/3] New remove-symbol-file command.
  - From: Blanc, Nicolas

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]