This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] dangling cleanup in find_frame_funname
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Wed, 22 May 2013 08:42:30 +0400
- Subject: Re: [RFA] dangling cleanup in find_frame_funname
- References: <51953293 dot 1020502 at redhat dot com> <20130520092358 dot GO4017 at adacore dot com> <519A6E0A dot 3000701 at redhat dot com> <20130521053301 dot GU4017 at adacore dot com> <519BF550 dot 5020504 at redhat dot com>
> ChangeLog
> 2013-05-21 Keith Seitz <keiths@redhat.com>
>
> * ada-lang.c (is_known_support_routine): Add explicit free of
> 'func_name' from find_frame_funname.
> (ada_unhandled_exception_name_addr_from_raise): Add cleanups
> for func_name from find_frame_funname.
> * python/py-frame.c (frapy_name): Add explicit free of
> 'name' from find_frame_funname.
> * stack.c (find_frame_funname): Add comment explaining that
> funcp must be freed by the caller.
> Return copy of symbol names instead of pointers.
> (print_frame): Add a cleanup for 'funname' from
> find_frame_funname.
> * stack.h (find_frame_funname): Remove "const" from
> 'funname' parameter.
JIC you haven't checked it in already - please feel free to go ahead,
and thank you for the fix, as always.
--
Joel