Re: [RFA] dangling cleanup in find_frame_funname

[Keith Seitz <keiths at redhat dot com>]

On 05/20/2013 10:33 PM, Joel Brobecker wrote:
> Looks good to me too. Just one tiny request, if I may:
[snip]
> Would you mind moving the call to make_cleanup that sets old_chain
> just before the "while". To me, that's useful, because the make_cleanup/
> do_cleanup calls bracket the while loop, showing that this is the
> context where the cleanup is used.

Sure.

> And while touching this area of the code, the "if (strcmp" line is
> indented with spaces-only, while it should be tabs-and-spaces
> (a PIA, if you ask me).

Emacs and vim both show there are definitely tabs there.

Keith

ChangeLog
2013-05-21  Keith Seitz  <keiths@redhat.com>

	* ada-lang.c (is_known_support_routine): Add explicit free of
	'func_name' from find_frame_funname.
	(ada_unhandled_exception_name_addr_from_raise): Add cleanups
	for func_name from find_frame_funname.
	* python/py-frame.c (frapy_name): Add explicit free of
	'name' from find_frame_funname.
	* stack.c (find_frame_funname): Add comment explaining that
	funcp must be freed by the caller.
	Return copy of symbol names instead of pointers.
	(print_frame): Add a cleanup for 'funname' from
	find_frame_funname.
	* stack.h (find_frame_funname): Remove "const" from
	'funname' parameter.

Attachment: find_frame_funname-dangling-cleanup
Description: Text document