This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch] Fix racy FAILs due to "read1" [Re: [PATCH] add -s option to make -break-insert support dprintf]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, tromey at redhat dot com, palves at redhat dot com, hui_zhu at mentor dot com, gdb-patches at sourceware dot org, marc dot khouzam at ericsson dot com
- Date: Tue, 21 May 2013 10:10:07 +0200
- Subject: [patch] Fix racy FAILs due to "read1" [Re: [PATCH] add -s option to make -break-insert support dprintf]
- References: <CANFwon3meTbHqy-kfibR6XiJpkZdS3348am2wP6i9Dbz_sowLg at mail dot gmail dot com> <87ehdehnc9 dot fsf at fleche dot redhat dot com> <CANFwon0NgSTcX+iuPsSPWU_t6O1UebETRrGvG7ghcAwC-MXTRA at mail dot gmail dot com> <838v3masbd dot fsf at gnu dot org> <CANFwon0cXTz+X2A_3Fz1kuc40H64siGYGtO6CRKyGeMw88ca2Q at mail dot gmail dot com> <834ne6an8h dot fsf at gnu dot org> <CANFwon0fMc6efT!tEVn_WLQ+8EaCzQ6f2AJH22jPg1RHyhnM2eg at mail dot gmail dot com> <CANFwon2V92hrOOvum+g5o+AFKLwNn+PsrKtskjdWJBoq95H_vg at mail dot gmail dot com> <83bo85wt9u dot fsf at gnu dot org> <CANFwon0zgYPbBdj4U-x_OqVUtjg35WAmMp1Gmyy6b=i6Ne-9qg at mail dot gmail dot com>
On Tue, 21 May 2013 06:24:16 +0200, Hui Zhu wrote:
> Checked in http://sourceware.org/ml/gdb-cvs/2013-05/msg00193.html
It has random FAILs during normal run:
+PASS: gdb.mi/mi-dprintf.exp: fprintf: mi 1st dprintf
+FAIL: gdb.mi/mi-dprintf.exp: fprintf: mi 1st dprintf stop (timeout)
+PASS: gdb.mi/mi-dprintf.exp: fprintf: mi 2nd dprintf
and when I tested it with:
reproducer for races of expect incomplete reads
http://sourceware.org/bugzilla/show_bug.cgi?id=12649
it FAILs reproducibly, could you review the proposed fix?
Thanks,
Jan
gdb/testsuite/
2013-05-21 Jan Kratochvil <jan.kratochvil@redhat.com>
PR testsuite/12649
* gdb.mi/mi-dprintf.exp (mi_continue_dprintf): Fix expect strings for
racy matches.
diff --git a/gdb/testsuite/gdb.mi/mi-dprintf.exp b/gdb/testsuite/gdb.mi/mi-dprintf.exp
index 457f332..ea8b3a8 100644
--- a/gdb/testsuite/gdb.mi/mi-dprintf.exp
+++ b/gdb/testsuite/gdb.mi/mi-dprintf.exp
@@ -68,7 +68,7 @@ proc mi_continue_dprintf {args} {
mi_run_cmd
set msg "mi 1st dprintf"
gdb_expect {
- -re ".*At foo entry.*arg=1234, g=1234.*" {
+ -re ".*At foo entry.*arg=1234, g=1234" {
pass $msg
}
-re ".*$mi_gdb_prompt$" {
@@ -83,7 +83,7 @@ proc mi_continue_dprintf {args} {
set msg "mi 2nd dprintf"
mi_send_resuming_command "exec-continue" "$msg continue"
gdb_expect {
- -re ".*At foo entry.*arg=1235, g=2222.*" {
+ -re ".*At foo entry.*arg=1235, g=2222.*$mi_gdb_prompt$" {
pass $msg
}
-re ".*$mi_gdb_prompt$" {