This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: contribution checklist in the wiki
- From: Doug Evans <dje at google dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Hui Zhu <teawater at gmail dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Mon, 20 May 2013 10:02:31 -0700
- Subject: Re: contribution checklist in the wiki
- References: <51965CE3 dot 4020805 at redhat dot com> <CANFwon1z0cNNsFDQmStrqR1awj8dejyRAMmqPN8Dy1xyKoRBiQ at mail dot gmail dot com> <519A36DA dot 3060009 at redhat dot com>
On Mon, May 20, 2013 at 7:44 AM, Pedro Alves <palves@redhat.com> wrote:
>> I have a question about format of changelog:
>> 2013-12-12 John Doe <johndoe@some.email.address>
>>
>> PR gdb/9999
>>
>> * breakpoint.c (handle_some_event): Remove reference to<line
>> wrap at or before column 79>
>>
>> If I remember is right, some people told me that there should not have
>> a empty line after "PR xxx".
>> And I checked the changelog, some of them have empty line and others don't have.
>>
>> So does it need a empty line after "PR xxx"?
>>
>
> Thanks for raising this. Doug expressed a preference for not having
> the empty line too off-list. I've now removed it from the wiki.
>
> I've been adding it, as to me it visually indicated the different
> areas - the "why/PR" area vs the "what" area. Skimming through the
> entries, it seems I was practically alone though. :-) I'll
> stop adding it from here on.
[for reference sake,]
For me when skimming a blank line means an unrelated patch.
[There's no requirement that each separate patch be preceded by a
name/timestamp line,
and emacs knows this.]
It's easy enough to pick out a new patch set starting with some
sentence or "PR 123"
instead of "* filename ...".