This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: reimplement AIX shared-lib support (v2)
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 25 Apr 2013 09:18:07 -0600
- Subject: Re: reimplement AIX shared-lib support (v2)
- References: <20130329004430 dot GK5993 at adacore dot com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> Any comments? Suggestions?
I noticed something minor.
Joel> + /* The pathname is actually a synthetic filename with the following
Joel> + form: "/path/to/sharedlib(member.o)" (double-quotes excluded).
Joel> + split this into archive name and member name.
Joel> +
Joel> + FIXME: This is a little hacky. Perhaps we should provide access
Joel> + to the solib's lm_info here? */
Joel> + const int path_len = strlen(pathname);
Space before open paren.
Joel> + /* Search for the associated parens. */
Joel> + len = path_len - 2;
Joel> + while (len > 1 && pathname[len] != '(')
Joel> + len--;
I think this can use strrchr.
Tom