This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix display of structures/bitfields in register description.
- From: Tom Tromey <tromey at redhat dot com>
- To: Walfred Tedeschi <walfred dot tedeschi at intel dot com>
- Cc: gdb-patches at sourceware dot org, drow at false dot org
- Date: Thu, 25 Apr 2013 07:53:39 -0600
- Subject: Re: [PATCH] Fix display of structures/bitfields in register description.
- References: <1366876919-29939-1-git-send-email-walfred dot tedeschi at intel dot com>
>>>>> "Walfred" == Walfred Tedeschi <walfred.tedeschi@intel.com> writes:
Walfred> Add support for displaying structures and bitfields for registers when
Walfred> executing the "maint print c-tdesc". Command is also used when
Walfred> converting the xml target description file into c file.
Thanks.
Walfred> testsuite/gdb.xml/
Walfred> * maint_print_struct.exp: New file.
Walfred> * maint_print_struct.xml: New file.
This is going to end up in testsuite/ChangeLog, so the file names should
start with "gdb.xml/".
Walfred> - if (type->kind == TDESC_TYPE_UNION
Walfred> + if ((type->kind == TDESC_TYPE_UNION ||
Walfred> + type->kind == TDESC_TYPE_STRUCT)
The GNU style is to break before the operator, not after, so the "||"
should go on the next line.
This patch is ok with those nits fixed, and with the .xml copyright
header changed. Thanks again.
Tom