This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bug 15181 Missing continue on dprintf that defaults to "gdb" style from "agent"


On 04/21/2013 07:06 PM, Hui Zhu wrote:
This patch is from Marc to fix
http://sourceware.org/bugzilla/show_bug.cgi?id=15181
I add a test for it.

Hui,
I am afraid that it is not correct to append "continue" command to dprintf commands, considering PR 15075 dprintf inteferes with "next". This patch <http://sourceware.org/ml/gdb-patches/2013-02/msg00736.html> removes "continue" command from dprintf commands, and it is reasonable to remove "continue", IMO. The patch is not perfect, as it disallows users setting commands to dprintf, and I prefer to support commands in dprintf, personally.

Since you are actively fixing dprintf bugs, feel free to take PR 15075 over, and fix it first. Then, PR 15181 may not be a bug at all.

--
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]