This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA PATCH] Enable -Wpointer-sign by default.
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 19 Apr 2013 21:16:41 +0300
- Subject: Re: [RFA PATCH] Enable -Wpointer-sign by default.
- References: <20130419175932 dot 13401 dot 30699 dot stgit at brno dot lan>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Pedro Alves <palves@redhat.com>
> Date: Fri, 19 Apr 2013 18:59:32 +0100
>
> +@item -Wpointer-sign
> +This helps make sure @value{GDBN} code uses @code{gdb_byte} which is
> +really @code{unsigned char} for raw bytes instead of @code{char},
> +whose signness is host-dependent. @sc{gcc} enables this with
> +@code{-Wall} since version 4.0. We enable it explicitly too to be
> +decoupled from future @sc{gcc} (or other compiler)'s choices.
I'd use "defaults" instead of "choices".
As for "other compilers": do other compilers really have, or are
likely to have, options that are named like that? If not, I suggest
to delete the part in the parentheses.
OK with those changes.
Thanks.