This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: jit_breakpoint_re_set_internal desc_symbol issue
- From: Doug Evans <dje at google dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 16 Apr 2013 13:24:02 -0700
- Subject: Re: jit_breakpoint_re_set_internal desc_symbol issue
- References: <yjt2mwt3s7u5 dot fsf at ruffy2 dot mtv dot corp dot google dot com>
On Fri, Apr 12, 2013 at 3:27 PM, Doug Evans <dje@google.com> wrote:
> [...]
> [
> ...
> Ultimately breakpoint_re_set gets called four times inside the call
> to post_create_inferior. There's some cleanup to be had here.
>
> To fix the jit.exp failure I might suggest just not caching jit.c:desc_symbol,
> except that if we're going to lookup the same symbol four times inside
> post_create_inferior that gives me pause.
> ]
Is there a well defined set of places where we need to start watching
for changes requiring breakpoint-resetting,
and a well defined set of places where we need the resetting done by?
Seems like there should be.
I was thinking IWBN if all the various places that need
breakpoint-resetting done could just (effectively) set a flag, and
have this flag checked in the few well-defined places that need it.
Plus, how much benefit would there be for more granularity? A lot of
times we just do a global resetting, when the code that needs the
resetting done only needs it for, say, a single objfile.