This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 21/26] -Wpointer-sign: dwarf2read.c.
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 12 Apr 2013 09:28:12 -0600
- Subject: Re: [PATCH 21/26] -Wpointer-sign: dwarf2read.c.
- References: <20130411225847 dot 16791 dot 29283 dot stgit at brno dot lan> <20130411230130 dot 16791 dot 4228 dot stgit at brno dot lan>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> This fixes the remaining issues necessary to make the DWARF reader
Pedro> -Wpointer-sign clean. The 'filename' bit should be obvious.
Pedro> 'constant_pool' holds the contents of an obstack, which are 'char *'.
Pedro> gdb_byte would work too, but it'd need more casts elsewhere, so I just
Pedro> chose the minimal approach. Any way would be fine with me.
I think this is fine.
Tom