This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] store trace default-collect to target [1/6] target, trace and remote
- From: "Abid, Hafiz" <hafiz_abid at mentor dot com>
- To: Hui Zhu <hui_zhu at mentor dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Thu, 11 Apr 2013 15:08:10 +0100
- Subject: Re: [PATCH] store trace default-collect to target [1/6] target, trace and remote
Hi Hui,
+ putpkt (buf);
+ remote_get_noisy_reply (&target_buf, &target_buf_size);
+ if (strcmp (target_buf, "OK"))
+ warning (_("\
Just a small comment on style. I think it is better to be explicit in
such case and write != 0. Also I was advised by Pedro recently that new
packets should be using packet_ok which will eliminate the need for
strcmp here anyway.
+ putpkt ("qTDC");
+ getpkt (&rs->buf, &rs->buf_size, 0);
+ if (strncmp (rs->buf, "DC", 2))
+ {
Why not remote_get_noisy_reply here.
Regards,
Abid