This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Include putpkt in TRY_CATCH. PR gdb/15275
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Gareth McMullin <gareth at blacksphere dot co dot nz>, gdb-patches at sourceware dot org
- Date: Tue, 02 Apr 2013 15:03:25 +0100
- Subject: Re: Include putpkt in TRY_CATCH. PR gdb/15275
- References: <CAL8qUbrD=fgMP7nE0O8tX=AXifUpQXas25o_4SfK4p79rfoUpw at mail dot gmail dot com> <CAL8qUbqjtBKJFJZ6dPS78Zh8Eb3b33U9JXTmn1pS3Le93xt7Rw at mail dot gmail dot com> <20130325195832 dot GA15218 at host2 dot jankratochvil dot net> <515478BE dot 3030801 at redhat dot com> <20130329140245 dot GA16492 at host2 dot jankratochvil dot net>
On 03/29/2013 02:02 PM, Jan Kratochvil wrote:
> On Thu, 28 Mar 2013 18:07:10 +0100, Pedro Alves wrote:
>> And detaching should
>> delete breakpoints from the target before sending "D" (although detach
>> command does, a detach caused by "quit" doesn't (if you "gdbserver --attach",
>
> I see it working:
Whoops. I remembered incorrectly where we're removing breakpoints.
>> gdb/
>> 2013-03-28 Pedro Alves <palves@redhat.com>
>>
>> PR gdb/15275
>>
>> * remote.c (send_interrupt_sequence): Use remote_serial_write.
>> (remote_serial_write): New function.
>> (putpkt_binary, getpkt_or_notif_sane_1): Use remote_serial_write.
>
> I agree this fix is better. I will revert the previous check-in after this
> check-in.
Now pushed.
Thanks,
--
Pedro Alves