This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] 4 of 5 - Frame filter testsuite changes
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 22 Mar 2013 09:19:15 -0600
- Subject: Re: [patch][python] 4 of 5 - Frame filter testsuite changes
- References: <513E5733 dot 6010800 at redhat dot com>
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> 2013-03-11 Phil Muldoon <pmuldoon@redhat.com>
Phil> * gdb.python/py-framefilter.py: New File.
Phil> * gdb.python/py-framefilter-mi.exp: Ditto.
Phil> * gdb.python/py-framefilter.c: Ditto.
Phil> * gdb.python/py-framefilter-mi.exp: Ditto.
Phil> * gdb.python/py-framefilter-mi.c: Ditto,
Phil> * gdb.python/py-framefilter-gdb.py.in: Ditto,
The two .c files look the same to me.
It is fine to reuse a .c file in different tests -- what isn't ok is
reusing the same executable file name, but you don't do that.
As we discussed in the other email and on irc, this should have tests
for nested blocks, block-less frames, and completion.
Otherwise this looks good to me.
Tom