This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC, testsuite] Remove semicolon after 'return'
On 03/15/2013 02:53 AM, Mark Kettenis wrote:
>> Date: Thu, 14 Mar 2013 21:33:37 +0800
>> From: Yao Qi <yao@codesourcery.com>
>>
>> On 03/14/2013 06:29 PM, Pedro Alves wrote:
>>> Looks good to me.
>>
>> Thanks for the fast review. Committed.
>
> A bit too fast though. You obviously did some sort of global search
> and replace. Unfortunately that also removed the semicolon in some
> comments containing C code examples. Can you put those back?
>
Yeah, I did global search/replace, manually inspect each change, and
revert it if it is a C code (we generate some C code in *.exp)....
> @@ -165,7 +165,7 @@ gdb_test "continue" "Continuing\\..*Breakpoint \[0-9\]+, main \\(argc=.*, argv=.
> # stop location, but avoids clutter when possible.
> #
> # Suppose you have a function written completely on one source line, like:
> -# int foo (int x) { return 0; }
> +# int foo (int x) { return 0 }
> # Setting a breakpoint at `foo' actually places the breakpoint after
> # foo's prologue.
> #
... miss this one. Committed the patch below, and thanks for spotting
it.
--
Yao (éå)
gdb/testsuite:
2013-03-15 Yao Qi <yao@codesourcery.com>
* gdb.base/condbreak.exp: Add semicolon back which was removed
by my previous commit.
---
gdb/testsuite/gdb.base/condbreak.exp | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gdb/testsuite/gdb.base/condbreak.exp b/gdb/testsuite/gdb.base/condbreak.exp
index 1f28c25..c09228c 100644
--- a/gdb/testsuite/gdb.base/condbreak.exp
+++ b/gdb/testsuite/gdb.base/condbreak.exp
@@ -165,7 +165,7 @@ gdb_test "continue" "Continuing\\..*Breakpoint \[0-9\]+, main \\(argc=.*, argv=.
# stop location, but avoids clutter when possible.
#
# Suppose you have a function written completely on one source line, like:
-# int foo (int x) { return 0 }
+# int foo (int x) { return 0; }
# Setting a breakpoint at `foo' actually places the breakpoint after
# foo's prologue.
#
--
1.7.7.6