This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Accelerate filenames matching
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 12 Mar 2013 10:48:14 -0700
- Subject: Re: [patch] Accelerate filenames matching
- References: <20130312132640.GA21810@host2.jankratochvil.net>
On Tue, Mar 12, 2013 at 6:26 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hi,
>
> I have read Doug's IRC line:
> xdje: In dw2_map_symtabs_matching_filename, in the case where compare_filenames_for_search succeeds, is there a point to falling through and trying again with the real path if dw2_map_expand_apply returns 0?
>
> So here is the fix. It could call the callback multiple times which may be
> considered a bug (I have not checked if it may be a problem for any of the
> callbacks).
>
> No regressions on {x86_64,x86_64-m32,i686}-fedora19pre-linux-gnu.
>
>
> Thanks,
> Jan
>
>
> gdb/
> 2013-03-12 Doug Evans <dje@google.com>
> Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * dwarf2read.c (dw2_map_symtabs_matching_filename): Put continue after
> any successful compare_filenames_for_search or FILENAME_CMP.
> * psymtab.c (partial_map_symtabs_matching_filename): Likewise.
> * symtab.c (iterate_over_some_symtabs): Likewise.
If there are no regressions, 'tis fine with me.
Thanks!