This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[COMMIT PATCH] linux-record.c:record_linux_system_call: fix -Wpointer-sign
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 07 Mar 2013 18:29:57 +0000
- Subject: [COMMIT PATCH] linux-record.c:record_linux_system_call: fix -Wpointer-sign
$ make WERROR_CFLAGS="-Wpointer-sign -Werror" linux-record.o 2>&1 1>/dev/null
...
../../src/gdb/linux-record.c: In function ârecord_linux_system_callâ:
../../src/gdb/linux-record.c:1152:9: error: pointer targets in passing argument 3 of âregcache_raw_read_signedâ differ in signedness [-Werror=pointer-sign]
In file included from ../../src/gdb/linux-record.c:23:0:
../../src/gdb/regcache.h:76:3: note: expected âlong int *â but argument is of type âlong unsigned int *â
../../src/gdb/linux-record.c:1186:13: error: pointer targets in passing argument 3 of âregcache_raw_read_signedâ differ in signedness [-Werror=pointer-sign]
In file included from ../../src/gdb/linux-record.c:23:0:
../../src/gdb/regcache.h:76:3: note: expected âlong int *â but argument is of type âlong unsigned int *â
I believe the read_signed calls are correct, and the variables are in
the wrong.
Tested on x86_64 Fedora 17.
gdb/
2013-03-07 Pedro Alves <palves@redhat.com>
* linux-record.c (record_linux_system_call) <gdb_sys_msgrcv,
RECORD_MSGRCV>: Pass a signed variable to
regcache_raw_read_signed, instead of an unsigned one.
---
gdb/linux-record.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/gdb/linux-record.c b/gdb/linux-record.c
index 5a9ec99..c769700 100644
--- a/gdb/linux-record.c
+++ b/gdb/linux-record.c
@@ -1148,10 +1148,11 @@ Do you want to stop the program?"),
case gdb_sys_msgrcv:
{
ULONGEST msgp;
+ LONGEST l;
- regcache_raw_read_signed (regcache, tdep->arg3, &tmpulongest);
+ regcache_raw_read_signed (regcache, tdep->arg3, &l);
regcache_raw_read_unsigned (regcache, tdep->arg2, &msgp);
- tmpint = (int) tmpulongest + tdep->size_long;
+ tmpint = l + tdep->size_long;
if (record_arch_list_add_mem ((CORE_ADDR) msgp, tmpint))
return -1;
}
@@ -1180,7 +1181,7 @@ Do you want to stop the program?"),
break;
case RECORD_MSGRCV:
{
- ULONGEST second;
+ LONGEST second;
ULONGEST ptr;
regcache_raw_read_signed (regcache, tdep->arg3, &second);