This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Don't need fast tracepoint in tstatus.exp
On 3/4/13 7:46 AM, Yao Qi wrote:
> tstatus.exp is used to test the output of 'tstatus' but there are some
> tests on fast tracepoint in it, which is not related to tstatus. This
> patch is to remove these fast tracepoint related stuff from tstatus.exp.
Even going back through old mail and notes, I simply cannot remember why
using fast tracepoints here seemed like a good idea. It doesn't even
look like a cut-n-paste from elsewhere, since there are small
differences from other uses. About the only thing I can think of is
that sometimes I want to mix up features a little in the testsuite, so
as to do double duty as unit test and integration test (which sounds a
little foolish now that I see it written down :-) ).
In any case, fast tracepoints do look like a distraction from the
business of tstatus testing, so I'm OK with this change.
Stan
stan@codesourcery.com
>
> gdb/testsuite:
>
> 2013-03-04 Yao Qi <yao@codesourcery.com>
>
> * gdb.trace/tstatus.exp: Use prepare_for_testing.
> (test_tracepoints): Don't set fast tracepoint.
> (top level): Don't check agent library is loaded or not.
> ---
> gdb/testsuite/gdb.trace/tstatus.exp | 41 +++-------------------------------
> 1 files changed, 4 insertions(+), 37 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.trace/tstatus.exp b/gdb/testsuite/gdb.trace/tstatus.exp
> index 8a0bbdf..483bb20 100644
> --- a/gdb/testsuite/gdb.trace/tstatus.exp
> +++ b/gdb/testsuite/gdb.trace/tstatus.exp
> @@ -34,22 +34,14 @@ if ![gdb_target_supports_trace] {
> return -1
> }
>
> -set libipa [get_in_proc_agent]
> -gdb_load_shlibs $libipa
> -
> -# Can't use prepare_for_testing, because that splits compiling into
> -# building objects and then linking, and we'd fail with "linker input
> -# file unused because linking not done" when building the object.
> -
> -if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
> - executable [list debug shlib=$libipa] ] != "" } {
> - untested "failed to compile ftrace tests"
> +if [prepare_for_testing $expfile $executable $srcfile \
> + {debug nowarnings} ] {
> + untested "failed to compile tracepoint tests"
> return -1
> }
> -clean_restart ${executable}
>
> if ![runto_main] {
> - fail "Can't run to main for ftrace tests"
> + fail "Can't run to main for tracepoint tests"
> return 0
> }
>
> @@ -141,34 +133,9 @@ proc test_tracepoints {} {
> gdb_trace_setactions "collect at set_point: define actions" \
> "" \
> "collect parm" "^$"
> - set fastgood 0
> -
> - gdb_test_multiple "ftrace gdb_recursion_test" "set fast tracepoint" {
> - -re "May not have a fast tracepoint at .*\r\n$gdb_prompt $" {
> - pass "4-byte fast tracepoint could not be set"
> - }
> - -re "Fast tracepoint .*\r\n$gdb_prompt $" {
> - pass "4-byte fast tracepoint is set"
> - set fastgood 1
> - }
> - }
> -
> - if { $fastgood } {
> -
> - gdb_trace_setactions "collect at four_byter: define actions" \
> - "" \
> - "collect globvar, anarg" "^$"
> - }
>
> run_trace_experiment
>
> }
>
> -gdb_reinitialize_dir $srcdir/$subdir
> -
> -if { [gdb_test "info sharedlibrary" ".*${libipa}.*" "IPA loaded"] != 0 } {
> - untested "Could not find IPA lib loaded"
> - return 1
> -}
> -
> test_tracepoints
>