This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix a bug in cmd_qtbuffer.
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 26 Feb 2013 11:23:19 +0000
- Subject: Re: [PATCH] Fix a bug in cmd_qtbuffer.
- References: <1361761876-10017-1-git-send-email-yao@codesourcery.com>
On 02/25/2013 03:11 AM, Yao Qi wrote:
> Hi,
> When playing with packet "qTBuffer", I find a bug in cmd_qtbuffer. We
> don't have to set '\0' to OWN_BUF, because convert_int_to_ascii did
> that. On the other hand, it is incorrect to set '\0' to own_buf[num]
> because convert_int_to_ascii writes 2 * num of bytes to OWN_BUF, it
> is correct to set '\0' to own_buf[2 * num]. This patch fixes the bug
> I found when using "qTBuffer".
>
> Regression tested on x86_64-linux. OK?
OK, thanks.
--
Pedro Alves