This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.

From: Joel Brobecker <brobecker at adacore dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
Date: Thu, 14 Feb 2013 13:04:51 -0800
Subject: Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
References: <20130214171404.2223.83713.stgit@brno.lan> <20130214171411.2223.32326.stgit@brno.lan> <87r4kiixbe.fsf@fleche.redhat.com> <511D2805.9050606@redhat.com> <87mwv6ix72.fsf@fleche.redhat.com> <511D2980.10703@redhat.com> <20130214185413.GJ17107@adacore.com> <877gmaiqg5.fsf@fleche.redhat.com>

> Joel> Lynx178 might also be an issue. Agreed on all other counts.
> Joel> I was hoping that gnulib would be our saviour, but maybe it does not
> Joel> implement everything we need (yet?).
> 
> It has xstrndup, though it seems a bit weird to pull in 2 different
> definitions of that function.  Also, gnulib updates seem tricky right
> now due to the libiconv situation.

Yeah, I was definitely thinking more long term... If the libiconv
situation is the only thing preventing us from doing an update,
I'd go ahead, because the only known platform where this is known
to potentially cause trouble is Lynx178, which I am going to guess
is a fairly little used system. And AFAICT, working around the issue
should be easily done by adding -DE...=... in CFLAGS when configuring
the debugger.

-- 
Joel

Follow-Ups:
- Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
  - From: Tom Tromey

References:
- [COMMIT PATCH 1/2] savestring: Rename parameter 'size' to 'len'.
  - From: Pedro Alves
- [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
  - From: Pedro Alves
- Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
  - From: Tom Tromey
- Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
  - From: Pedro Alves
- Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
  - From: Tom Tromey
- Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
  - From: Pedro Alves
- Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
  - From: Joel Brobecker
- Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]