This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Patch] Get trace file name when using 'target tfile'
- From: Pedro Alves <palves at redhat dot com>
- To: "Abid, Hafiz" <hafiz_abid at mentor dot com>
- Cc: eliz at gnu dot org, Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org, marc dot khouzam at ericsson dot com
- Date: Thu, 14 Feb 2013 15:57:00 +0000
- Subject: Re: [Patch] Get trace file name when using 'target tfile'
- References: <1360856970.2842.4@abidh-ubunto1104>
On 02/14/2013 03:49 PM, Abid, Hafiz wrote:
> Thanks everybody for review. The updated patch is attached. The changes from the previous version are.
>
> 1. Renamed "from_file" field to "filename". Use explicit NULL(or non-NULL) check against it.
> 2. Added a test case for -trace-struct command.
> 3. Added NEWS entry.
>
> How does it look?
Thanks. The code bits looks good to me.
Eli should review the new NEWS bit.
> * remote.c (remote_get_trace_status): Initialize "filename"
> field with NULL instead of 0.
^^^^
Something weird with spaces here.
--
Pedro Alves