This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Patch] Get trace file name when using 'target tfile'
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: "Abid, Hafiz" <hafiz_abid at mentor dot com>, gdb-patches at sourceware dot org, marc dot khouzam at ericsson dot com
- Date: Thu, 14 Feb 2013 14:34:15 +0000
- Subject: Re: [Patch] Get trace file name when using 'target tfile'
- References: <1360766298.2842.0@abidh-ubunto1104> <511C56FE.7000503@codesourcery.com>
On 02/14/2013 03:16 AM, Yao Qi wrote:
> On 02/13/2013 10:38 PM, Abid, Hafiz wrote:
>> - /* This is true if the status is coming from a file rather
>> - than a live target. */
>> - int from_file;
>> + /* If the status is coming from a file rather than a live target,
>> + this points at the file's filename. Otherwise, this is NULL. */
>> + const char *from_file;
>
> How about rename this field to "trace_filename", or something similar? "from_file" is fine as a boolean, but is confusing as a the name of trace file.
Fine with me. I'd drop the "trace_" bit as being redundant
with "struct trace_status".
--
Pedro Alves