Re: RFC: fix PR symtab/11464

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Mon, 11 Feb 2013 21:28:05 +0100, Tom Tromey wrote:
> This is quite strange.  Today I rebased this patch onto gdb/master.
> Then I built gdb without the patch and ran the test case that was
> included in the patch.  In gdb.log I then see:
> 
>     ptype gnu_obj_1::'~gnu_obj_1'
>     ERROR: Process no longer exists

That's true, that crashes even for me.  I still expected it crashes for you if
you remove the two lines:
         if (classification == NAME)
           break;
which cannot / does not crash.


> Jan> So I still believe those two lines
> Jan>         if (classification == NAME)
> Jan>           break;
> Jan> are just some cleanup/simplification but not required by this patch.
> 
> Ok, I see what you mean, but the subsequent line is not valid for NAME:
> 
> 	  context_type = yylval.tsym.type;

OK, that makes sense now.

(It cannot crash but I agree it is not clean to read such data.)


> I guess you are saying I should invert the if.
> Ok, I will do that.

No, I did not mean that.  In fact I do not understand much what condition
inversion do you mean.

I am fine with the patch now.


Thanks,
Jan