This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Handle bitfields inside inner structs for internalvars

On Mon, 11 Feb 2013 19:05:58 +0100, Sergio Durigan Junior wrote:
> On Saturday, February 09 2013, Jan Kratochvil wrote:
> > Otherwise I was curious - what to do if value_parent exists but TOVAL is not
> > a bitfield?  Isn't it a forgotten case?  (It is not but...)
> 
> According to comments in gdb/value.{c,h}, value_parent is only used iff
> the we are dealing with bitfields, so I guess this case is covered
> (otherwise it is a bug).  Was it a rhetorical question?

I expected a future reader may have such a question.

I just believed the code was worth some comment, thanks for it.  If it were
absolutely clear the bug would not happen there in the first place.


Thanks,
Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]