This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] revised FreeBSD PowerPC support
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Andreas Tobler <andreast-list at fgznet dot ch>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 3 Feb 2013 07:11:53 -0800
- Subject: Re: [patch] revised FreeBSD PowerPC support
- References: <510C38DB.1020407@fgznet.ch>
Hi Andreas,
> 2013-02-01 Andreas Tobler <andreast@fgznet.ch>
>
> * Makefile.in (ALL_TARGET_OBS): Add powerpc FreeBSD files.
> * configure.host: Add powerpc*-*-freebsd* target.
> * configure.tgt: Add target info for powerpc*-*-freebsd*.
> * ppcfbsd-nat.c, ppcfbsd-tdep.h, ppcfbsd-tdep.c: New files.
> * config/powerpc/fbsd.mh: New file.
I only quickly scanned your patch, and just happened to notice
that the .mh file is missing a copyright header. I know that most
.mh files do not have one, and yours is probably small enough that
we could get away with it, but we're trying to be a little more
consistent about this now. Thank you!
> Index: config/powerpc/fbsd.mh
> --- /dev/null
> +++ config/powerpc/fbsd.mh
> @@ -0,0 +1,5 @@
> +# Host: FreeBSD/powerpc
> +NATDEPFILES= fbsd-nat.o fork-child.o inf-ptrace.o ppcfbsd-nat.o bsd-kvm.o
> +
> +LOADLIBES= -lkvm
> +
--
Joel