This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: fix PR 13987
On 01/24/2013 05:55 PM, Tom Tromey wrote:
> Tom> Maybe I see -- the objfile is attached to a progspace, not an inferior.
> Tom> So we have to look for inferiors using this progspace instead of
> Tom> assuming the current inferior.
>
> Tom> Is that what you mean? Or if not, can you walk me through it some more?
>
> Pedro> I meant, that even if it was attached to an inferior, there is no
> Pedro> hard guarantee that the current inferior would be the one
> Pedro> the breakpoint is attached to. But yes, that too.
>
> Here's a follow-up patch that reworks jit.c to attach its data to the
> program space, not the inferior. This cleans up a couple of messy bits:
> jit_breakpoint_deleted is now much more direct, and free_objfile_data
> doesn't rely on the current inferior or program space at all, as it can
> now examine the objfile directly.
>
> Built and regtested on x86-64 Fedora 16.
>
> What do you think?
I think it makes sense and looks good.
> I'm going to hold the earlier patch pending this one, since I think the
> two together make the most sense.
Thanks. Go ahead.
--
Pedro Alves