This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove redundant condition checking.
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 15 Jan 2013 14:37:50 +0000
- Subject: Re: [PATCH] Remove redundant condition checking.
- References: <1358242261-16209-1-git-send-email-yao@codesourcery.com>
On 01/15/2013 09:31 AM, Yao Qi wrote:
> The condition '!single_inst' is checked in both [1] and [2], but the
> checking in [2] is not necessary. This patch is to remove the
> checking in [2], because I don't see keep it in [2] helps
> understanding the code. It is obvious to me, but the review is still
> welcome.
Yes, certainly fine.
> * infcmd.c (step_once): Don't check '!single_inst' as it was
> check before.
"was checked".
--
Pedro Alves