This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/commit 1/3] minor ravenscar-thread cleanup


> I question the pushing of this target from the inferior_created observer.
> Detecting the ravenscar runtime is based on looking for some symbols,
> so it would seem to me that doing that from a new_objfile observer
> (which is what e.g., linux-thread-db.c, another thread_stratum target,
> does) would be more correct (e.g., it'd work to attach to a target,
> notice missing symbols, and point GDB at symbols, at which point GDB
> would load a new objfile and detect ravenscar).

You are probably right, I need to look into it. I want to get rid
of some of the globals - I will look into all of this at the same
time.

Note that the patch itself does not change anything at the moment,
it just inlines one function into the observer code.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]