This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RFC: make lookup_solib_trampoline_symbol_by_pc static
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 12 Dec 2012 09:29:06 -0700
- Subject: RFC: make lookup_solib_trampoline_symbol_by_pc static
I noticed that lookup_solib_trampoline_symbol_by_pc only has a single
caller.
This patch makes it static.
If there is some reason to keep it public, let me know. Otherwise I
plan to check this in.
Tom
2012-12-12 Tom Tromey <tromey@redhat.com>
* minsyms.c (lookup_solib_trampoline_symbol_by_pc): Now static.
* minsyms.h (lookup_solib_trampoline_symbol_by_pc): Don't
declare.
Index: minsyms.c
===================================================================
RCS file: /cvs/src/src/gdb/minsyms.c,v
retrieving revision 1.93
diff -u -r1.93 minsyms.c
--- minsyms.c 11 Sep 2012 21:26:16 -0000 1.93
+++ minsyms.c 12 Dec 2012 16:28:09 -0000
@@ -1302,9 +1302,11 @@
build_minimal_symbol_hash_tables (objfile);
}
-/* See minsyms.h. */
+/* Check if PC is in a shared library trampoline code stub.
+ Return minimal symbol for the trampoline entry or NULL if PC is not
+ in a trampoline code stub. */
-struct minimal_symbol *
+static struct minimal_symbol *
lookup_solib_trampoline_symbol_by_pc (CORE_ADDR pc)
{
struct obj_section *section = find_pc_section (pc);
Index: minsyms.h
===================================================================
RCS file: /cvs/src/src/gdb/minsyms.h,v
retrieving revision 1.3
diff -u -r1.3 minsyms.h
--- minsyms.h 4 Jan 2012 08:17:06 -0000 1.3
+++ minsyms.h 12 Dec 2012 16:28:09 -0000
@@ -228,12 +228,6 @@
struct minimal_symbol *lookup_minimal_symbol_by_pc (CORE_ADDR);
-/* Check if PC is in a shared library trampoline code stub.
- Return minimal symbol for the trampoline entry or NULL if PC is not
- in a trampoline code stub. */
-
-struct minimal_symbol *lookup_solib_trampoline_symbol_by_pc (CORE_ADDR);
-
/* Iterate over all the minimal symbols in the objfile OBJF which
match NAME. Both the ordinary and demangled names of each symbol
are considered. The caller is responsible for canonicalizing NAME,