This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v9 1/3] MI: add the -catch-load and -catch-unload commands
- From: Mircea Gherzan <mircea dot gherzan at intel dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org, keven dot boell at intel dot com, marc dot khouzam at ericsson dot com, vladimir at codesourcery dot com
- Date: Tue, 11 Dec 2012 15:54:44 +0100
- Subject: Re: [PATCH v9 1/3] MI: add the -catch-load and -catch-unload commands
- References: <1355145401-7438-1-git-send-email-mircea.gherzan@intel.com> <876249ej4b.fsf@fleche.redhat.com>
On 10.12.2012 21:40, Tom Tromey wrote:
"Mircea" == Mircea Gherzan <mircea.gherzan@intel.com> writes:
Mircea> +++ b/gdb/mi/mi-cmd-break.h
[...]
Mircea> +/* Setup the reporting of the insertion of a new breakpoint or
Mircea> + catchpoint. */
Mircea> +struct cleanup *
Mircea> +setup_breakpoint_reporting (void);
No break after the "*" here.
Mircea> + char *actual_cmd = load ? "-catch-load" : "-catch-unload";
Should be const.
This is ok with those fixes.
This and Vladimir's suggestion have been incorporated in v10 of the series.
Can you please merge the series yourself? I don't have "write after
approval" permission.
Thanks,
Mircea
--
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052