This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/6] Test tracepoints are installed or not

From: Pedro Alves <palves at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>
Cc: gdb-patches at sourceware dot org
Date: Fri, 07 Dec 2012 14:20:42 +0000
Subject: Re: [PATCH 5/6] Test tracepoints are installed or not
References: <1354596282-32526-1-git-send-email-yao@codesourcery.com> <1354596282-32526-6-git-send-email-yao@codesourcery.com> <50C1E38F.2020108@redhat.com> <50C1F553.8030502@codesourcery.com>

On 12/07/2012 01:55 PM, Yao Qi wrote:
> On 12/07/2012 08:39 PM, Pedro Alves wrote:
>> I don't understand this part.  Why do we get two notifications?  Different calls to the
>> breakpoint_modified observers?  This also relates to the "installed" field being present
>> or not for pending breakpoints issue I pointed out in a previous patch.  It'd be good to
> 
> When pending tracepoint is resolved, breakpoint_modified observer is notified, and then, when tracepoint is downloaded, the breakpoint_modified observer is notified again.

Okay.  Could you add a comment mentioning this in the test?

Thanks,
-- 
Pedro Alves

Follow-Ups:
- Re: [PATCH 5/6] Test tracepoints are installed or not
  - From: Yao Qi

References:
- [PATCH 0/6] Add a new field 'installed' when reporting tracepoint
  - From: Yao Qi
- [PATCH 5/6] Test tracepoints are installed or not
  - From: Yao Qi
- Re: [PATCH 5/6] Test tracepoints are installed or not
  - From: Pedro Alves
- Re: [PATCH 5/6] Test tracepoints are installed or not
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]