This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Several sprintf removal, non-trivial
- From: Tom Tromey <tromey at redhat dot com>
- To: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 27 Nov 2012 11:32:26 -0700
- Subject: Re: [RFC] Several sprintf removal, non-trivial
- References: <44519.786097999$1353454347@news.gmane.org>
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> Comments most welcome,
Thanks for doing this.
A few random nits, nothing too serious.
Pierre> @@ -6516,29 +6516,29 @@ xdb_handle_command (char *args, int from
[...]
I think this one would be clearer just using xstrprintf, but seeing that
it is an xdb command, I think it doesn't matter.
Pierre> @@ -4574,7 +4576,7 @@ linux_proc_pending_signals (int pid, sig
Pierre> sigemptyset (pending);
Pierre> sigemptyset (blocked);
Pierre> sigemptyset (ignored);
Pierre> - sprintf (fname, "/proc/%d/status", pid);
Pierre> + xsnprintf (fname, MAXPATHLEN, "/proc/%d/status", pid);
I think this one can use sizeof.
Pierre> +++ src/gdb/mi/mi-main.c 16 Nov 2012 16:03:56 -0000
Pierre> @@ -1143,19 +1143,22 @@ get_register (struct frame_info *frame,
Pierre> if (format == 'r')
Pierre> {
Pierre> - int j;
Pierre> + int j, pos, size;
Here you don't need a separate 'pos' variable since the code is already
advancing 'ptr' through the buffer. pos == ptr - buf at all times.
Pierre> @@ -1543,20 +1546,25 @@ mi_cmd_data_read_memory_bytes (char *com
Likewise in this function.
Pierre> Index: src/gdb/mt-tdep.c
[...]
Pierre> }@@ -184,6 +184,7 @@ mt_register_name (struct gdbarch *gdbarc
Pierre> unsigned dim_1;
Pierre> unsigned dim_2;
Pierre> unsigned index;
Pierre> + int name_len = 30;
This isn't needed.
Pierre> Index: src/gdb/tracepoint.c
Pierre> ===================================================================
Pierre> RCS file: /cvs/src/src/gdb/tracepoint.c,v
Pierre> retrieving revision 1.269
Pierre> diff -u -p -r1.269 tracepoint.c
Pierre> --- src/gdb/tracepoint.c 9 Nov 2012 19:58:02 -0000 1.269
Pierre> +++ src/gdb/tracepoint.c 16 Nov 2012 16:03:55 -0000
Pierre> @@ -1230,7 +1230,7 @@ stringify_collection_list (struct collec
Pierre> {
Pierre> char temp_buf[2048];
Pierre> char tmp2[40];
Pierre> - int count;
Pierre> + int count, pos, size;
This is another spot where you don't need 'pos'.
Pierre> Index: src/gdb/utils.c
Pierre> ===================================================================
Pierre> RCS file: /cvs/src/src/gdb/utils.c,v
Pierre> retrieving revision 1.286
Pierre> diff -u -p -r1.286 utils.c
Pierre> --- src/gdb/utils.c 22 Aug 2012 17:48:55 -0000 1.286
Pierre> +++ src/gdb/utils.c 16 Nov 2012 16:03:55 -0000
Pierre> @@ -3590,7 +3590,7 @@ const char *
Pierre> gdb_bfd_errmsg (bfd_error_type error_tag, char **matching)
Pierre> {
Pierre> char *ret, *retp;
Pierre> - int ret_len;
Pierre> + int ret_len, ret_pos, size;
Pierre> char **p;
Here too.
Pierre> + int len = strlen (namespace_name) + 2 + strlen (name) + 1;
Why int and not size_t?
Tom