This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
FYI: use SYMBOL_SYMTAB accessor
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 26 Nov 2012 08:53:59 -0700
- Subject: FYI: use SYMBOL_SYMTAB accessor
While working on a different patch I noticed a few spots that were not
using the SYMBOL_SYMTAB accessor macro.
This patch fixes these places. I'm checking it in as obvious.
Tested by rebuilding.
Tom
2012-11-26 Tom Tromey <tromey@redhat.com>
* ada-lang.c (user_select_syms): Use SYMBOL_SYMTAB.
* dwarf2read.c (dw2_find_symbol_file, fixup_go_packaging): Use
SYMBOL_SYMTAB.
* skip.c (skip_info): Use SYMBOL_SYMTAB.
Index: ada-lang.c
===================================================================
RCS file: /cvs/src/src/gdb/ada-lang.c,v
retrieving revision 1.380
diff -u -r1.380 ada-lang.c
--- ada-lang.c 12 Nov 2012 17:14:54 -0000 1.380
+++ ada-lang.c 26 Nov 2012 15:51:01 -0000
@@ -3583,7 +3583,7 @@
(SYMBOL_CLASS (syms[i].sym) == LOC_CONST
&& SYMBOL_TYPE (syms[i].sym) != NULL
&& TYPE_CODE (SYMBOL_TYPE (syms[i].sym)) == TYPE_CODE_ENUM);
- struct symtab *symtab = syms[i].sym->symtab;
+ struct symtab *symtab = SYMBOL_SYMTAB (syms[i].sym);
if (SYMBOL_LINE (syms[i].sym) != 0 && symtab != NULL)
printf_unfiltered (_("[%d] %s at %s:%d\n"),
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.713
diff -u -r1.713 dwarf2read.c
--- dwarf2read.c 20 Nov 2012 22:51:04 -0000 1.713
+++ dwarf2read.c 26 Nov 2012 15:51:06 -0000
@@ -3402,7 +3402,7 @@
struct symbol *sym = lookup_block_symbol (block, name, VAR_DOMAIN);
if (sym)
- return sym->symtab->filename;
+ return SYMBOL_SYMTAB (sym)->filename;
}
return NULL;
}
@@ -6754,8 +6754,9 @@
if (strcmp (package_name, this_package_name) != 0)
complaint (&symfile_complaints,
_("Symtab %s has objects from two different Go packages: %s and %s"),
- (sym->symtab && sym->symtab->filename
- ? sym->symtab->filename
+ (SYMBOL_SYMTAB (sym)
+ && SYMBOL_SYMTAB (sym)->filename
+ ? SYMBOL_SYMTAB (sym)->filename
: cu->objfile->name),
this_package_name, package_name);
xfree (this_package_name);
Index: skip.c
===================================================================
RCS file: /cvs/src/src/gdb/skip.c,v
retrieving revision 1.8
diff -u -r1.8 skip.c
--- skip.c 9 Aug 2012 06:48:21 -0000 1.8
+++ skip.c 26 Nov 2012 15:51:06 -0000
@@ -304,7 +304,7 @@
if (sym)
ui_out_field_fmt (current_uiout, "what", "%s at %s:%d",
sym->ginfo.name,
- sym->symtab->filename,
+ SYMBOL_SYMTAB (sym)->filename,
sym->line);
else
ui_out_field_string (current_uiout, "what", "?");