This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary


> Date: Wed, 21 Nov 2012 13:10:55 +0000
> From: Pedro Alves <palves@redhat.com>
> 
> I updated my checkout this morning and stumbled on:
> 
> ../../src/gdb/i386-tdep.c: In function ?i386_skip_prologue?:
> ../../src/gdb/i386-tdep.c:1586:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
> cc1: all warnings being treated as errors
> 
> I also noticed the indentation of the if block is not according to
> the convention.
> 
> I can't find an email approving the change.  Was there some private
> discussion perhaps?

I did not approve that change.  I haven't had the time to properly
review the change yet, but it is almost certainly wrong.  Please back
it out.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]