This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
FYI: fix a FIXME in put_frame_register
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 05 Nov 2012 14:42:27 -0700
- Subject: FYI: fix a FIXME in put_frame_register
I'm checking this in as obvious.
I randomly happened to notice an obsolete FIXME in put_frame_register.
write_memory does take a const buffer now, so no temporary is needed.
Built and regtested on x86-64 Fedora 16.
Tom
2012-11-05 Tom Tromey <tromey@redhat.com>
* frame.c (put_frame_register): Don't use temporary buffer.
diff --git a/gdb/frame.c b/gdb/frame.c
index a2f23a4..71f0ba4 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -1077,12 +1077,7 @@ put_frame_register (struct frame_info *frame, int regnum,
{
case lval_memory:
{
- /* FIXME: write_memory doesn't yet take constant buffers.
- Arrrg! */
- gdb_byte tmp[MAX_REGISTER_SIZE];
-
- memcpy (tmp, buf, register_size (gdbarch, regnum));
- write_memory (addr, tmp, register_size (gdbarch, regnum));
+ write_memory (addr, buf, register_size (gdbarch, regnum));
break;
}
case lval_register: