This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Support up to 3 conditional branches in an atomic sequence
- From: Pedro Alves <palves at redhat dot com>
- To: Anton Blanchard <anton at samba dot org>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org
- Date: Fri, 28 Sep 2012 12:44:04 +0100
- Subject: Re: [PATCH 2/3] Support up to 3 conditional branches in an atomic sequence
- References: <20120606135557.7da37cbe@kryten> <20120606135655.57bd5b54@kryten> <20120613160208.GH18729@adacore.com> <20120716163355.74acba34@kryten>
Hi Anton,
Just some notes on the ChangeLog formatting:
On 07/16/2012 07:33 AM, Anton Blanchard wrote:
> 2012-06-05 Anton Blanchard <anton@samba.org>
>
> * gdb/breakpoint.h: Define MAX_SINGLE_STEP_BREAKPOINTS
> * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Allow for more
> than two breakpoints.
> * gdb/breakpoint.c (insert_single_step_breakpoint): Likewise
> (insert_single_step_breakpoint): Likewise
> (single_step_breakpoints_inserted): Likewise
> (cancel_single_step_breakpoints): Likewise
> (detach_single_step_breakpoints): Likewise
> (single_step_breakpoint_inserted_here_p): Likewise
- Please add a period at the end of these sentences.
- Remove the gdb/ from the breakpoint.h|c entries.
I suggest:
2012-09-28 Anton Blanchard <anton@samba.org>
* breakpoint.h (MAX_SINGLE_STEP_BREAKPOINTS): New define.
* rs6000-tdep.c (ppc_deal_with_atomic_sequence): Allow for more
than two breakpoints.
* breakpoint.c (insert_single_step_breakpoint): Likewise.
(insert_single_step_breakpoint): Likewise.
(single_step_breakpoints_inserted): Likewise.
(cancel_single_step_breakpoints): Likewise.
(detach_single_step_breakpoints): Likewise.
(single_step_breakpoint_inserted_here_p): Likewise.
--
Pedro Alves