[committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

[KARTHIKVENKATESH BHAT <kv dot bhat at samsung dot com>]

Thanks for the review. Committed after formatting.

------- Original Message -------
Sender : Joel Brobecker<brobecker@adacore.com>
Date : Sep 26, 2012 00:49 (GMT+09:00)
Title : Re: [PATCH] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

Karthik,

Thanks for the fix.

> +2012-09-25  Karthik Bhat  
> + 
> + * alpha-tdep.c (arm_skip_prologue): Extending support for LLVM compiler. 
Wrong filename. The patch looks good and is OK to commit provided
you fix the formatting issue outlined below.

Do you have a copyright assignment on file? This patch is small enough
that it can be accepted without one, but if you are planing on
contributing more changes, having one would become necessary.
Let me know if you need to get started on the paperwork.

> Index: gdb/arm-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> retrieving revision 1.367
> diff -u -p -r1.367 arm-tdep.c
> --- gdb/arm-tdep.c 22 Aug 2012 19:47:56 -0000 1.367
> +++ gdb/arm-tdep.c 25 Sep 2012 13:34:54 -0000
> @@ -1400,7 +1400,7 @@ arm_skip_prologue (struct gdbarch *gdbar
>        if (post_prologue_pc
>     && (s == NULL
>         || s->producer == NULL
> -       || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0))
> +       || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0 || strncmp (s->producer, "clang ", sizeof ("clang ") - 1) == 0))

Please move the addition || condition on the next line, properly aligned
with the others.

-- 
Joel