This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] Delete unused functions in sol-thread.c.


> Fine with me either way.

OK - I will fix the formatting issue, and commit separately.

> > gdb/ChangeLog:
> > 
> >         * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
> >         Move these functions to sol-sparc-thread.c.
> >         * sol-sparc-thread.c: New file.
> 
> Following gdb naming de facto convention this new file would be named
> sparc-sol-thread.c though (as e.g., amd64-linux-nat.c, etc.).

But we already have ravenscar-sparc-thread.c :). I guess we should fix
that too. Global consistency is probably better than per-topic
consistency...

Thanks for the review. I'll work on the last few details as soon as
I have a moment.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]