This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] Delete unused functions in sol-thread.c.

On 09/20/2012 10:43 PM, Joel Brobecker wrote:

> gdb/ChangeLog:
> 
>         * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
>         Enable this code for sparc hosts only.

Looks good to me, with

> +#if defined(__sparc) || defined(__sparcv9)

space before parens.

> gdb/ChangeLog:
> 
>         * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
>         Remove commented-out code.

There's more '#if 0'-related code in the file.  I think that if we're
removing these, we should get rid of all of it.

I found it curious that
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libc_db/common/thread_db.c
says "Currently unused by dbx"...

-- 
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]