This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] wrong language used when re-setting breakpoint


> I think the breakpoint re-setting code should be temporarily setting
> current_language.  breakpoint_re_set does this.

I kind of agree, but ... at the same time, this type of changes then
makes it harder for us to make progress in getting rid of the
current_language global, no?

Also, I think that relying on the global being set for a defined period
of time is a little risky. It seems too easy for the current_language
to change right from under us as a side-effect of some sub-action.

> I don't have a problem with your patch.  I think it is an improvement.
> But I think it is important to understand why the current mechanism
> isn't working, since I think a failure here may have other bad effects
> as well.

OK - I will commit the patch, then. But I think we'd be better off
trying to find the other bad effects, and see if we can use a parameter
to fix them, rather than making sure the global is set properly.
The problem with my suggested approach, however, is that we have
to wait for bugs that reveal those bad effects.

Thanks,
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]