This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: consolidate checks for _Unwind_DebugHook in test suite


On Tue, 14 Aug 2012 18:20:14 +0200, Tom Tromey wrote:
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
[...]
> +proc skip_unwinder_tests {} {
> +    global gdb_prompt
> +
> +    set ok 1
> +    gdb_test_multiple "print _Unwind_DebugHook" "check for unwinder hook" {
> +	-re "= .*no debug info.*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
> +	    # Pass the test so we don't get bogus fails in the results.
> +	    pass "check for unwinder hook"
> +	    set ok 0
> +	}
> +	-re "= .*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
> +	    pass "check for unwinder hook"
> +	}
> +	-re "No symbol .* in current context.\r\n$gdb_prompt $" {
> +	    # Pass the test so we don't get bogus fails in the results.
> +	    pass "check for unwinder hook"
> +	    set ok 0
> +	}
> +    }

If gdb_test_multiple FAILs it will leave "ok" as 1 which will run the whole
testfile.  Was it intentional?  Maybe it was although I would expect the
opposite.


Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]