This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: consolidate checks for _Unwind_DebugHook in test suite


Yao> Do we really need to put "pass" here?  skip_* proc in lib/gdb.exp is
Yao> to do some check and return a boolean value.  We don't have to
Yao> generate any PASS or FAIL during checking.  I'd like to remove them.

I would like that too, but you can't really use gdb_test_multiple
without these, because it may emit fails on its own.

I think that is a bad factoring -- there should be a way to interact
with gdb without muddying affecting the test count.  But right now there
isn't.

I wouldn't mind if someone changed this, but this patch is just a
straightforward refactoring.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]