Re: [SH] regs command

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi!

On Wed, 06 Jun 2012 20:10:02 +0200, I wrote:
> On Wed, 16 May 2012 18:31:30 +0200, I wrote:
> > On Wed, 16 May 2012 07:26:33 -0700, Joel Brobecker <brobecker@adacore.com> wrote:
> > > > I therefore propose to remove sh_show_regs_command et al. from sh-tdep.c.
> > > > If nobody objects, can it just go silently, or should invoking it then
> > > > cause an error message, like ÂPlease use the Âinfo all-registers command
> > > > instead of ÂregsÂ.Â?
> > > 
> > > Make it an alias of "info reg" or "info all-registers", and make
> > > the alias deprecated, so that users get a warning when they use it?
> 
> Below is the patch that I finally committed.
> 
> > > We can make that command deprecated for 7.5, and then remove it
> > > from HEAD after 7.5 is branched, in a few weeks.
> 
> I'll prepare a patch for that.

... and here it is.  OK to commit?

gdb/
	* NEWS: Document the removal of SH's 'regs' command.
	* sh-tdep.c (_initialize_sh_tdep): Remove the deprecated 'regs'
	command.

gdb/doc/
	* gdb.texinfo: Document the removal of SH's 'regs' command.

Index: NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.538
diff -u -p -r1.538 NEWS
--- NEWS	6 Aug 2012 17:13:26 -0000	1.538
+++ NEWS	10 Aug 2012 09:15:04 -0000
@@ -20,6 +20,12 @@
 maint info bfds
   List the BFDs known to GDB.
 
+* Removed commands
+
+  ** For the Renesas Super-H architecture, the "regs" command has been removed
+     (has been deprecated in GDB 7.5), and "info all-registers" should be used
+     instead.
+
 *** Changes in GDB 7.5
 
 * GDB now supports x32 ABI.  Visit <http://sites.google.com/site/x32abi/>
Index: sh-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sh-tdep.c,v
retrieving revision 1.246
diff -u -p -r1.246 sh-tdep.c
--- sh-tdep.c	22 Jul 2012 16:52:41 -0000	1.246
+++ sh-tdep.c	10 Aug 2012 09:15:04 -0000
@@ -2416,16 +2418,8 @@ extern initialize_file_ftype _initialize
 void
 _initialize_sh_tdep (void)
 {
-  struct cmd_list_element *c;
-
   gdbarch_register (bfd_arch_sh, sh_gdbarch_init, NULL);
 
-  /* We can't use an alias here because 'info registers' has not yet been
-     registered.  */
-  c = add_com ("regs", class_vars, all_registers_info,
-               _("Print all registers"));
-  deprecate_cmd (c, "info all-registers");
-
   add_prefix_cmd ("sh", no_class, set_sh_command, "SH specific commands.",
                   &setshcmdlist, "set sh ", 0, &setlist);
   add_prefix_cmd ("sh", no_class, show_sh_command, "SH specific commands.",
Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.994
diff -u -p -r1.994 gdb.texinfo
--- doc/gdb.texinfo	2 Aug 2012 09:27:15 -0000	1.994
+++ doc/gdb.texinfo	10 Aug 2012 09:15:05 -0000
@@ -20471,13 +20471,6 @@ For the Renesas Super-H processor, @valu
 commands:
 
 @table @code
-@item regs
-@kindex regs@r{, Super-H}
-This command is deprecated, and @code{info all-registers} should be
-used instead.
-
-Show the values of all Super-H registers.
-
 @item set sh calling-convention @var{convention}
 @kindex set sh calling-convention
 Set the calling-convention used when calling functions from @value{GDBN}.


GrÃÃe,
 Thomas

Attachment: pgp00000.pgp
Description: PGP signature