This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 0/5] Explicit linespecs


> Date: Sun, 29 Jul 2012 11:50:43 -0700
> From: Keith Seitz <keiths@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> On 07/27/2012 04:03 AM, Eli Zaretskii wrote:
> 
> > What exactly does the "offset" option do?  Is it a line offset, or is
> > it measured in other units?  If it's a line offset, then why not call
> > it "-line"?  If "offset" means it's a relative line offset, then what
> > is it relative to?
> 
> It is completely analogous to the linespec parser. It could be an 
> absolute line number (if -source given) or relative (if 
> -function/-label).

We need to explain all that in the manual.  It is completely
non-obvious.

> I can certainly rename the option to be more user-friendly.

IMO, we should indeed rename it.

> > Also, the above doesn't seem to cover the magical '*function' location
> > spec.
> 
> That's the -address option.

This should also be explained.  "Valid code address" certainly does
not hint of it.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]