This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/10] change gdb to refcount bfd everywhere
Jan> There was some conclusion on gdb-patches to make happy both people
Jan> wanting comments in *.c and people wanting comments in *.h and to
Jan> prevent duplication of the same comment in both *.c and *.h which
Jan> leads to stale invalid comments in one of the files to put the
Jan> comment only in *.h file and in the *.c file state: /* See
Jan> gdb_bfd.h. */ You even use it at various functions in gdb_bfd.c,
Jan> just not for gdb_bfd_ref and gdb_bfd_unref.
Tom> I'll fix it.
Here's the patch.
Tom
2012-07-23 Tom Tromey <tromey@redhat.com>
* gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Fix comment.
Index: gdb_bfd.c
===================================================================
RCS file: /cvs/src/src/gdb/gdb_bfd.c,v
retrieving revision 1.6
diff -u -r1.6 gdb_bfd.c
--- gdb_bfd.c 23 Jul 2012 14:57:54 -0000 1.6
+++ gdb_bfd.c 23 Jul 2012 15:00:55 -0000
@@ -218,7 +218,7 @@
return ret;
}
-/* Add reference to ABFD. Returns ABFD. */
+/* See gdb_bfd.h. */
void
gdb_bfd_ref (struct bfd *abfd)
@@ -242,7 +242,7 @@
bfd_usrdata (abfd) = gdata;
}
-/* Unreference and possibly close ABFD. */
+/* See gdb_bfd.h. */
void
gdb_bfd_unref (struct bfd *abfd)