This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Make SIZE element for dwarf_block as size_t


>>>>> "Siddhesh" == Siddhesh Poyarekar <siddhesh@redhat.com> writes:

Siddhesh> A small adjustment to this patch to adjust for the expansion of
Siddhesh> dwarf_block.size -- a couple of local variables in decode_locdesc
Siddhesh> needed expansion as well.

What about dwarf2_evaluate_loc_desc_full?
It has 'unsigned short size' as an argument but is called from
indirect_pieced_value:

  struct dwarf2_locexpr_baton baton;
[...]
  return dwarf2_evaluate_loc_desc_full (TYPE_TARGET_TYPE (type), frame,
					baton.data, baton.size, baton.per_cu,
					piece->v.ptr.offset + byte_offset);


It would have been useful to me if you had written a bit about how you
wrote this patch and verified it.  As it is, with no information on
that, I went grepping through the source to see if the patch was
complete.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]