This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Create utils.h and host-defs.h, move gdb_vecs.h to common.
- From: Tom Tromey <tromey at redhat dot com>
- To: dje at google dot com
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Jul 2012 14:24:45 -0600
- Subject: Re: [patch] Create utils.h and host-defs.h, move gdb_vecs.h to common.
- References: <yjt2liiimfik.fsf@ruffy2.mtv.corp.google.com>
>>>>> "Doug" == Douglas Evans <dje@google.com> writes:
Doug> It's just a code reorg:
Doug> - creates utils.h and moves (almost) all the utils.c decls there from defs.h.
Doug> I left QUIT&co in defs.h.
Doug> - moves gdb_vecs.h to common and creates common/gdb_vecs.c.
Doug> I have a followup patch that uses gdb_vecs.c functions in gdbserver.
Doug> - creates common/host-defs.h, DIRNAME_SEPARATOR is needed by gdb_vecs.c.
Doug> - moves probe_p out of gdb_vecs.h, I think a better place for it is probe.h.
It all seems reasonable to me.
Tom