This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Add multiple branches to single step through atomic sequence testcase
- From: Anton Blanchard <anton at samba dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 16 Jul 2012 16:43:32 +1000
- Subject: Re: [PATCH 3/3] Add multiple branches to single step through atomic sequence testcase
- References: <20120606135557.7da37cbe@kryten> <20120606135828.0d87f888@kryten> <20120613160613.GI18729@adacore.com>
Hi Joel,
> I won't pretend I understand PowerPC code all that well, I only know
> the basics. My only concern with this change is whether you might have
> reduced the number of conditions being tested. I would have expected
> this patch to *add* more code, and associated changes in the .exp
> file. But apparently, the code update is sufficient. How does the
> change work? I see two labels used twice, for instance?
We don't have to update the .exp file because the entire larx/stcx
appears as a single stepi, regardless of what we put inside it. I added
the duplicate labels to test the duplicate branch detection in the
previous patch:
+ /* Check for duplicated breakpoints. */
+ for (index2 = 0; index2 < index; index2++)
The gdb single step code has always handled this but since I was
shifting code around I figured it was a good idea to test it.
Anton