This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
> -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Jan Kratochvil > Sent: Wednesday, May 30, 2012 10:44 PM Thanks for your review! [...] > > + if (packet->support != PACKET_ENABLE) > > + { > > + errno = ENOSYS; > > errno is not used for intra-GDB/gdbserver communication. Everywhere. I'll look into error handling. > > + return NULL; > > + } > > + > > + buf += xsnprintf (buf, endbuf - buf, "%s", packet->name); buf += > > + xsnprintf (buf, endbuf - buf, ":on:"); buf = write_ptid (buf, > > + endbuf, ptid); putpkt (rs->buf); getpkt (&rs->buf, &rs->buf_size, > > + 0); > > + > > + switch (packet_ok (rs->buf, packet)) > > + { > > + case PACKET_OK: > > + tinfo = xzalloc (sizeof (*tinfo)); > > + if (tinfo) > > Remove, xzalloc can never fail. Fixed. > > + tinfo->ptid = ptid; > > + else > > + errno = ENOMEM; > > + break; > > + case PACKET_ERROR: > > + { > > + int pid = ptid_get_lwp (ptid); > > + if (!pid) > > + pid = ptid_get_pid (ptid); > > + > > + error (_("Couldn't enable btrace for %d: %s"), > > + pid, rs->buf); > > Use target_pid_to_str. Everywhere. Fixed. [...] > > + struct cleanup *cleanup = make_cleanup (xfree, xml); > > Empty line after declarations. Fixed. [...] Regards, Markus.
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
-------------------------------------------------------------------------------------- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |